[FFmpeg-devel] [PATCH] libavfilter-soc: implement draw_slice in vf_setpts.c

Stefano Sabatini stefano.sabatini-lala
Fri Jan 2 19:23:20 CET 2009


On date Friday 2009-01-02 16:25:34 +0100, Michael Niedermayer encoded:
> On Fri, Jan 02, 2009 at 12:00:30PM +0100, V?ctor Paesa wrote:
> > Hi,
> > 
> > Stefano Sabatini said:
> > > Hi all,
> > >
> > > vf_setpts.c currently has no draw_slice callback, when used in a
> > > filter chain like this:
> > >
> > > ffplay -f video4linux -s 320x240 /dev/video -vfilters "[in]
> > > setpts=PTS-STARTPTS, hflip, [T1] overlay=0:0 [out]; SOME_SOURCE,
> > > setpts=PTS-STARTPTS [T1]"
> > >
> > > no .draw_slice function is called from setpts, resulting in no picture
> > > being passed to the hflip filter, patch fixes it.
> > 
> > Thanks Stefano, it fixes the green background reported in:
> > http://lists.mplayerhq.hu/pipermail/ffmpeg-user/2008-November/017726.html
> > 
> > I'd say it's OK.
> 
> is there a reason why its not done in avfilter_draw_slice() ?

I don't know, and maybe the attached patch provides a more general
solution.

Regards.
-- 
FFmpeg = Fast and Fostering Mysterious Puritan Elitarian Guide
-------------- next part --------------
A non-text attachment was scrubbed...
Name: extend-draw-slice.patch
Type: text/x-diff
Size: 2237 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090102/c66eb9d7/attachment.patch>



More information about the ffmpeg-devel mailing list