[FFmpeg-devel] ALAC regression test

[Diego Biurrun]

On Mon, Jan 05, 2009 at 03:10:23PM +0530, Jai Menon wrote:
> 
> On Mon, Jan 5, 2009 at 1:43 PM, Jai Menon <jmenon86 at gmail.com> wrote:
> >
> > On Mon, Jan 5, 2009 at 1:12 PM, Mike Melanson <mike at multimedia.cx> wrote:
> >> Since FFmpeg has both an ALAC encoder and decoder, shouldn't it be
> >> tested through 'make test'? I checked and this is not the case. I also
> >> verified that decoding a file encoded with FFmpeg's ALAC encoder
> >> produces a bit-identical file.
> >>
> >> I tried to add 'alac' to the main Makefile at the CODEC_TESTS rule but
> >> that didn't seem to do anything useful. I bring it up so that someone
> >> more knowledgeable might make the right modifications.
> >
> > My bad :-) Michael had asked me to add a regression test for alac at
> > the end of review and I guess I forgot.
> > I'll try and post a patch for that soon.
> 
> I added a quick test for ffalac. The patch may or may not be correct :-)
> Please comment.

Should be OK if it works.  No, I haven't checked in detail...

Diego