[FFmpeg-devel] [PATCH]Possible configure support for VDPAU

[Diego Biurrun]

On Mon, Jan 05, 2009 at 03:18:03AM +0100, Carl Eugen Hoyos wrote:
>
> Attached patch implements configure (and shared library) support for  
> VDPAU.
> If the library is compiled on a system where no VDPAU headers are  
> installed, it cannot use VDPAU. Still, this patch installs a (possibly  
> useless) vdpau_render.h. Is this wanted?

I think yes, VDPAU headers/support could be installed later.

> configure does not die if --enable-vdpau was used, but the necessary  
> headers are missing, but simply disables vdpau.

It behaves similarly in other cases.

> --- configure	(revision 16431)
> +++ configure	(working copy)
> @@ -1041,6 +1043,7 @@
>  libx264_encoder_deps="libx264"
>  libxvid_encoder_deps="libxvid"
>  mpeg4aac_decoder_deps="libfaad"
> +vdpau_deps="vdpau_vdpau_h vdpau_vdpau_x11_h"

Shouldn't this be h264_vdpau_decoder_deps?

> @@ -1827,6 +1830,8 @@
>  check_header sys/select.h
>  check_header termios.h
>  check_header X11/extensions/XvMClib.h
> +check_header vdpau/vdpau.h
> +check_header vdpau/vdpau_x11.h

This was in alphabetical order before.

> --- libavcodec/Makefile	(revision 16431)
> +++ libavcodec/Makefile	(working copy)
> @@ -3,7 +3,7 @@
>  
> -HEADERS = avcodec.h opt.h
> +HEADERS = avcodec.h opt.h vdpau_render.h

I wonder if vdpau_render.h is a good name for the header.

Diego