[FFmpeg-devel] [PATCH] Drop AVFrac at the next lavf major bump

Stefano Sabatini stefano.sabatini-lala
Tue Jan 6 22:40:33 CET 2009


On date Tuesday 2009-01-06 00:48:38 +0100, Michael Niedermayer encoded:
> On Tue, Jan 06, 2009 at 12:00:58AM +0100, Stefano Sabatini wrote:
> > On date Monday 2009-01-05 23:03:10 +0100, Diego Biurrun encoded:
> > > On Mon, Jan 05, 2009 at 11:18:29PM +0100, Michael Niedermayer wrote:
[...]
> > > > > > You were the one who marked AVFrac deprecated.  I assumed you had a
> > > > > > reason for this.
> > > > 
> > > > i did, i thought we could avoid it just by AVRational & int64_t but this
> > > > didnt work out
> > 
> > Are we sure we can't avoid AVFrac using AVRational + int64_t?  (This
> > is not a rethorical question, as for me I'm still not sure.)
> 
> you can do it with 1bit variables and NAND doesnt mean it is a good idea
> though ...
> 
> 
> > 
> > If we can avoid it, we should, since AVFrac is used just for one var
> > and keeping a public struct (with a private interface) for just one
> > use doesn't look nice.
> > 
> 
> > The one advantage of AVRational64 with respect to AVFrac is that it
> > seems to require less computations, also it doesn't need specific
> > functions (av_frac_init/av_frac_add) to deal with it, so looks simpler
> > to me.
> 
> AVRational64 without any way to add, multiple, divide, ... them and with
> just a single use ...

So what about to export the AVFrac interface? If it's useful in FFmpeg
then it may be useful in other places too...

Regards.
-- 
FFmpeg = Funny and Free Murdering Pacific Epic Gospel




More information about the ffmpeg-devel mailing list