[FFmpeg-devel] [PATCH] ADTS AAC with ID3v2

[Alex Converse]

On Wed, Jan 14, 2009 at 2:48 AM, Diego Biurrun <diego at biurrun.de> wrote:

> On Wed, Jan 14, 2009 at 12:23:00AM -0500, Alex Converse wrote:
> >
> > The attached patch adds support to the ADTS AAC probe to detect AAC files
> > with ID3v2 tags at a higher level than the MP3 probe and the MPC probe.
> It
> > refactors some id3 detection from mp3.c into id3v2.c.
> >
> > --- /dev/null
> > +++ b/libavformat/id3v2.c
> > @@ -0,0 +1,35 @@
> > +/*
> > + * ID3v2 header parser
> > + * Copyright (c) 2003 Fabrice Bellard.
>
> Drop the silly period.
>
> > --- /dev/null
> > +++ b/libavformat/id3v2.h
> > @@ -0,0 +1,30 @@
> > +/*
> > + * ID3v2 header parser
> > + * Copyright (c) 2003 Fabrice Bellard.
>
> ditto
>

This makes mp3.c is the second file I've created copies of that had these
periods. Perhaps we should go through the source and find all of these.


>
> > +#include <stdint.h>
>
> multiple inclusion guards
>
> > --- a/libavformat/raw.c
> > +++ b/libavformat/raw.c
> > @@ -26,6 +26,10 @@
> >  #include "raw.h"
> > +#if CONFIG_AAC_DEMUXER
> > +#include "id3v2.h"
> > +#endif
>
> pointless #if
>
> Diego
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at mplayerhq.hu
> https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel
>