[FFmpeg-devel] [PATCH] remove CONFIG_AUDIO_NONSHORT

[Aurelien Jacobs]

Michael Niedermayer wrote:

> On Thu, Jan 15, 2009 at 12:30:27AM +0100, Aurelien Jacobs wrote:
> > Michael Niedermayer wrote:
> > 
> > > On Wed, Jan 14, 2009 at 11:15:49PM +0100, Aurelien Jacobs wrote:
> > > > Hi,
> > > > 
> > > > CONFIG_AUDIO_NONSHORT is never set anywhere (and IIRC it never was).
> > > > Do the related code have any use for anyone ?
> > > > Maybe we could simply drop this useless code like with attached patch.
> > > > Anyway, it's very simple and could be added back latter is someone
> > > > feel the need.
> > > 
> > > CONFIG_AUDIO_NONSHORT should be considered to be 1
> > 
> > I'm fine with this too. Just note that it was never enabled before,
> 
> so a benchmark would be usefull ...

I'm not really interested by this code, so someone else will have
to do it.

> > and that enabling it changes regtest results.
> > See attached patch.
> 
> [...]
> > -stddev: 4394.71 PSNR: 23.46 bytes:  1053352/  1058444
> > +stddev: 4785.84 PSNR: 22.72 bytes:  1053352/  1058444
> 
> why does this become worse?

No idea.

For now I've explicitly disabled CONFIG_AUDIO_NONSHORT (just making
explicit what has always been implicit).
If anyone is really interested by this, feel free to benchmark and
study the psnr decrease before enabling it.

Aurel