[FFmpeg-devel] [PATCH] libx264 psyrd update V2

[Michael Niedermayer]

On Sat, Jan 17, 2009 at 11:08:32AM +0100, Marcus Blomenkamp wrote:
> Hi all,
> 
> the original patches (patch 2 actually) contained errors, thus once again: 
> 
> x264 mainline now contains psychovisualization enhancements (psyrd) and enables them by default.
> 
> Patch 1 adds support for these new configuration options.
> Patch 2 updates the libx264 preset files to make use of them by default.
> 
[...]
> diff -u -r -N ffmpeg-export-2009-01-15.orig/libavcodec/avcodec.h ffmpeg-export-2009-01-15/libavcodec/avcodec.h
> --- ffmpeg-export-2009-01-15.orig/libavcodec/avcodec.h	Tue Jan 13 19:13:08 2009
> +++ ffmpeg-export-2009-01-15/libavcodec/avcodec.h	Sat Jan 17 06:56:47 2009
> @@ -2075,6 +2075,20 @@
>      float crf;
>  
>      /**
> +     * Strength of psychovisual optimization - rate distortion optimization
> +     * - encoding: Set by user.
> +     * - decoding: unused
> +     */
> +    float psy_rd;
> +
> +    /**
> +     * Strength of psychovisual optimization - trellis
> +     * - encoding: Set by user.
> +     * - decoding: unused
> +     */
> +    float psy_trellis;
> +
> +    /**
>       * constant quantization parameter rate control method
>       * - encoding: Set by user.
>       * - decoding: unused

you cannot add fields in the middle this breaks ABI
also the documentation is a little too terse

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I know you won't believe me, but the highest form of Human Excellence is
to question oneself and others. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090117/4d88628b/attachment.pgp>