[FFmpeg-devel] [PATCH] ALSA for libavdevice

[Diego Biurrun]

On Mon, Jan 19, 2009 at 09:02:37PM +0100, Nicolas George wrote:
> 
> This new version adds a few line of documentation, including a link to the
> ALSA bug tracker entry, and a run-time warning about the issue. It appears
> that, when the bug actually hits, the warning is indeed the last thing
> displayed.
> 
> --- /dev/null
> +++ b/libavdevice/alsa-audio-dec.c
> @@ -0,0 +1,174 @@
> +    sample_rate = ap->sample_rate;
> +    codec_id = ap->audio_codec_id;

This could be aligned.

> +static int audio_read_packet(AVFormatContext *s1, AVPacket *pkt)
> +{
> +    AlsaData *s = s1->priv_data;
> +    AVStream *st = s1->streams[0];

This could be aligned.

> +AVInputFormat alsa_demuxer = {
> +    "alsa",
> +    NULL_IF_CONFIG_SMALL("Alsa audio input"),

ALSA

> --- /dev/null
> +++ b/libavdevice/alsa-audio-enc.c
> @@ -0,0 +1,108 @@
> +
> +    st = s1->streams[0];
> +    sample_rate = st->codec->sample_rate;
> +    codec_id = st->codec->codec_id;

This could be aligned.

> +static int audio_write_packet(AVFormatContext *s1, AVPacket *pkt)
> +{
> +    AlsaData *s = s1->priv_data;
> +    int res;
> +    int size= pkt->size;
> +    uint8_t *buf= pkt->data;

This would be more readable with a space before the = and could be aligned.

> +AVOutputFormat alsa_muxer = {
> +    "alsa",
> +    NULL_IF_CONFIG_SMALL("Alsa audio output"),

ALSA

Diego