[FFmpeg-devel] [PATCH] Hold fft.c to the same standards being applied to new code

Michael Niedermayer michaelni
Wed Jan 21 01:45:10 CET 2009


On Tue, Jan 20, 2009 at 06:29:02PM -0500, Alex Converse wrote:
> On Tue, Jan 20, 2009 at 6:13 PM, Diego Biurrun <diego at biurrun.de> wrote:
> > On Tue, Jan 20, 2009 at 05:35:46PM -0500, Alex Converse wrote:
> >> Attached are two patches to make fft.c comply with the same standards
> >> being applied to new code (RDFT)
> >
> > Both look OK, just a small nit:
> >
> >> --- a/libavcodec/dsputil.h
> >> +++ b/libavcodec/dsputil.h
> >> @@ -683,10 +688,17 @@ void ff_fft_calc_3dn(FFTContext *s, FFTComplex *z);
> >>
> >> +/**
> >> + * Do the permutation needed BEFORE calling ff_fft_calc()
> >
> > Add a period while you're at it.
> >
> 
> fixed

looks ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Opposition brings concord. Out of discord comes the fairest harmony.
-- Heraclitus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090121/351d89fd/attachment.pgp>



More information about the ffmpeg-devel mailing list