[FFmpeg-devel] [RFC] Public API for RC4 and DES

[Michael Niedermayer]

On Fri, Jan 30, 2009 at 01:48:27PM +0000, M?ns Rullg?rd wrote:
> Reimar D?ffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de> writes:
> 
> > On Fri, Jan 30, 2009 at 12:10:06AM +0100, Michael Niedermayer wrote:
> >> On Wed, Jan 28, 2009 at 03:17:27PM +0100, Reimar D?ffinger wrote:
> >> > @@ -150,17 +152,22 @@
> >> >      }
> >> >  
> >> >      memset(rc4buff, 0, sizeof(rc4buff));
> >> > -    ff_rc4_enc(key, 12, (uint8_t *)rc4buff, sizeof(rc4buff));
> >> > +    rc4 = av_malloc(av_rc4_size);
> >> 
> >> uint8_t rc4v[av_rc4_size];
> >> struct AVRC4 *rc4= (void*)rc4v;
> >
> > I was thinking about that, it just seemed horribly ugly...
> 
> It smells of misalignment.

then add DECLARE_ALIGNED()
or use uint64_t

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In a rich man's house there is no place to spit but his face.
-- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090130/8dfda57e/attachment.pgp>