[FFmpeg-devel] [PATCH] validate theora time_base

Michael Niedermayer michaelni
Thu Jul 2 14:21:14 CEST 2009

On Thu, Jul 02, 2009 at 02:07:33PM +0200, Reimar D?ffinger wrote:
> Hello,
> oggparsetheora reads time_base without any checks, which cause the crash
> (division by 0) in issue1240, ogv/smclock.ogv.1.0.ogv.
> I also have some doubts if the values are ever properly reduced, but that is a
> different issue.
> This patch fixes the issue, though the default time_base from the ogg container
> (IIRC corresponds to 100000 fps or something like that) is quite off, so it might
> be better to just ignore the st->time_base and override it to 25 fps instead.
> I leave all that to the maintainer...

iam in favor of 25 or return -1 and an error message either way

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Asymptotically faster algorithms should always be preferred if you have
asymptotical amounts of data
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090702/8d0568e5/attachment.pgp>

More information about the ffmpeg-devel mailing list