[FFmpeg-devel] [PATCH] OpenEXR decoder rev-3

[Jimmy Christensen]

On 2009-07-02 17:35, Vitor Sessak wrote:
> Ronald S. Bultje wrote:
>> Hi,
>>
>> On Thu, Jul 2, 2009 at 11:28 AM, Vitor Sessak<vitor1001 at gmail.com> wrote:
>>> Jimmy Christensen wrote:
>>>> + switch (bits_per_color_table[bits_per_color_id]) {
>>>> + case 32:
>>>> + avctx->pix_fmt = PIX_FMT_RGB48LE;
>>>> + break;
>>>> + case 16:
>>>> + avctx->pix_fmt = PIX_FMT_RGB48LE;
>>>> + break;
>>>> + default:
>>>> + av_log(avctx, AV_LOG_ERROR, "Unkown color format : %d\n",
>>>> bits_per_color_id);
>>> Same
>> [av_log_missing_feature()]
>>
>> "Invalid" != "Not implemented", right? This looks like "invalid" to me.
>
> Quoting the first message in this thread:
>
>> 8-bit integer is in theory supported aswell by the format, but I have
>> yet to find software which supports writing it
>
> So it is more a "sample welcome" case.
>

I think a better way of doing it is making an av_log_missing_feature for 
8-bit and an invalid for anything above 0x2 which is 32-bit. 0x0 - 0x2 
is the only ones mentioned in the documentation of the format.

-- 
Best Regards
Jimmy Christensen
Developer
Ghost A/S