[FFmpeg-devel] [PATCH] OpenEXR decoder rev-4

Jimmy Christensen jimmy
Fri Jul 3 11:04:33 CEST 2009

Have updated a lot of things and restructured the code a bit.

Still using the reference 32-bit float converter as I couldn't figure 
out how to make a function like Reimar's, work for 32-bit float.

Reimar, perhaps you could help me out? :)

>> +        strcpy(variable_buffer_name, buf);
>> +        buf += strlen(variable_buffer_name)+1;
>> +        strcpy(variable_buffer_type, buf);
>> +        buf += strlen(variable_buffer_type)+1;
> One possible buffer overflow after the other.
> Apart from that, I don't see the point why you make those copies,
> variable_buffer_type is not used at all, and variable_buffer_name can
> be compared in-place.

Not sure how to do this otherwise. The variable_buffer_name is always of 
different size and only uses 0x0 as a delimiter. Keeping the 
variable_buffer_type is to be able to use it for later in the 
interpretation of the different variables. And it also serves for the 
purpose of knowing how many bytes to skip to get to the actual data.

Everything else should hopefully be fixed.

Best Regards
Jimmy Christensen
Ghost A/S
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenEXR-rev4.diff
Type: text/x-patch
Size: 12940 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090703/bce9a328/attachment.bin>

More information about the ffmpeg-devel mailing list