[FFmpeg-devel] [PATCH] validate theora time_base
Fri Jul 3 13:31:20 CEST 2009
On Thu, Jul 02, 2009 at 04:20:20PM +0200, Michael Niedermayer wrote:
> On Thu, Jul 02, 2009 at 02:59:29PM +0200, Reimar D?ffinger wrote:
> > On Thu, Jul 02, 2009 at 02:21:14PM +0200, Michael Niedermayer wrote:
> > > On Thu, Jul 02, 2009 at 02:07:33PM +0200, Reimar D?ffinger wrote:
> > > > Hello,
> > > > oggparsetheora reads time_base without any checks, which cause the crash
> > > > (division by 0) in issue1240, ogv/smclock.ogv.1.0.ogv.
> > > > I also have some doubts if the values are ever properly reduced, but that is a
> > > > different issue.
> > > > This patch fixes the issue, though the default time_base from the ogg container
> > > > (IIRC corresponds to 100000 fps or something like that) is quite off, so it might
> > > > be better to just ignore the st->time_base and override it to 25 fps instead.
> > > > I leave all that to the maintainer...
> > >
> > > iam in favor of 25 or return -1 and an error message either way
> > Ok:
More information about the ffmpeg-devel