[FFmpeg-devel] [PATCH] vp6_parse_coeff_huffman misses buffer size check

Reimar Döffinger Reimar.Doeffinger
Sun Jul 5 18:06:14 CEST 2009

On Sun, Jul 05, 2009 at 05:05:21PM +0200, Aurelien Jacobs wrote:
> On Sun, Jul 05, 2009 at 02:19:52PM +0200, Reimar D?ffinger wrote:
> > affected file is vp62/smclockvp62hsp.avi.1.1 from issue 1240.
> > One solution is just to check if there is still data available for every
> > coded coefficient. Given the overall complexity of the code that might
> > even be acceptable, no idea.
> Well, not very nice, but I have no better idea, and the slowdown is
> barely mesurable. So, patch OK.

Well, see r19322 for a method that avoids performance overhead (though possibly
adding a cache overhead). It seemed to me that it's not such a great idea
for this function though.

More information about the ffmpeg-devel mailing list