[FFmpeg-devel] [PATCH] 4 of 5 Add Speex Encoding
Tue Jul 7 00:35:15 CEST 2009
On 07/06/2009 03:27 PM, Art Clarke wrote:
>> Please check Justin's patch:
>> [FFmpeg-devel] [PATCH] speex in ogg muxer
> I hadn't seen Justin's patch. He's got it the muxer mostly right -- except
> he should let the encoder set avctx->extradata and use it for the speex
> header packet if it's there.
Like this in Justin's patch ?
+ bytestream_put_buffer(&p, avctx->extradata, SPEEX_HEADER_SIZE);
Your patch duplicates the comment part.
Justin had some concerns about overhead in ogg files, don't you have
these concerns ?
Baptiste COUDURIER GnuPG Key Id: 0x5C1ABAAA
Key fingerprint 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
FFmpeg maintainer http://www.ffmpeg.org
More information about the ffmpeg-devel