[FFmpeg-devel] [PATCH] 5 of 5 Add Speex Encoding

Michael Niedermayer michaelni
Tue Jul 7 16:29:20 CEST 2009

On Mon, Jul 06, 2009 at 05:52:43PM -0700, Art Clarke wrote:
> On Mon, Jul 6, 2009 at 4:34 PM, Justin Ruggles <justin.ruggles at gmail.com>wrote:
> Here's what I found.  Set the speex frames per packet all the way from 1 up
> to 8, and it appears they all now work with Flash Player (I erroneously
> reported that 1 would not work before, but at least with the latest version
> that is not the case).  Setting 9 frames per packet causes flash player to
> start stuttering.  Set 10 or more frames per packet causes flash player to
> crash, bringing down the browser with it.

Can that be exploited? ;)

seriously, this one probably should be reported ...

> So my suggestion is:
> 1) set the default frames per packet in libspeexenc.c to 2, as Adobe does
> (and my patch did).

seems reasonable ...

> 2) in flvenc.c, either don't enforce the frames-per-packet (assume the user
> knows what they are doing) or just warn people if is not between 1 and 8.

i think iam in favor of letting the user shoot himself, if that is what he
asks for, that said thats just a very weak oppinion of mine, i dont mind
a check ...

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Republics decline into democracies and democracies degenerate into
despotisms. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090707/b0d9c0f9/attachment.pgp>

More information about the ffmpeg-devel mailing list