[FFmpeg-devel] [PATCH] 5 of 5 Add Speex Encoding

[Art Clarke]

On Tue, Jul 7, 2009 at 7:29 AM, Michael Niedermayer <michaelni at gmx.at>wrote:

> Can that be exploited? ;)
>
> seriously, this one probably should be reported ...
>

Yeah... but I'm disinclined to do it given Adobe's less-than-stellar record
in responding to these :)


> > 2) in flvenc.c, either don't enforce the frames-per-packet (assume the
> user
> > knows what they are doing) or just warn people if is not between 1 and 8.
>
> i think iam in favor of letting the user shoot himself, if that is what he
> asks for, that said thats just a very weak oppinion of mine, i dont mind
> a check ...
>

Any suggestions on the best way to make this configurable in libspeexenc.c?
My default idea is to add (yet another) field at the end of AVCodecContext
named "frames_per_packet", make it settable in libavcodec/options.c, and
then use it in libspeexenc.c (and potentially any other codecs that need
it).  This would be a minor version bump for libavcodec.

- Art


-- 
http://www.xuggle.com/
xu?ggle (z?' gl) v. To freely encode, decode, and experience audio and
video.

Use Xuggle to get the power of FFmpeg in Java.