[FFmpeg-devel] [PATCH] AAC: reject multiple channel configurations

Robert Swain robert.swain
Wed Jul 8 00:16:28 CEST 2009


2009/7/7 Alex Converse <alex.converse at gmail.com>:
> Invalid second channel configurations are one of the biggest causes of
> crashes in the AAC deocder in my experience. See issue 1254 for an
> example. If they are even legal is dubious at best. From 14496-3:2005:


> Even if they are legal we aren't reliably able to handle them at the
> moment so they should be disabled.

Agreed. Thank you for the extensive and thorough argument, it's much
appreciated. :)

> The attached patch does not break conformance.

Which issues does it fix? It would be good to have this in the commit
message if possible.

> You may be curious why the patch does not just error out completely.
> It is clear from the spec that the redundant PCE must be parsed.
> Erroring would break concatenation of compatible ADTS files that
> contain a PCE.

Patch OK, except I think the string in the av_log() should rather be
"Not evaluating a further program_config_element as this construct is
dubious at best." It need not necessarily be the second and I think
the reason is tied to the action. And I guess you'll reindent
afterwards. :)


More information about the ffmpeg-devel mailing list