[FFmpeg-devel] [PATCH] qtrleenc: Add RGB555 and ARGB pixel formats support
Wed Jul 8 11:07:01 CEST 2009
2009/7/8 Carl Eugen Hoyos <cehoyos at ag.or.at>:
> Alexis Ballier <alexis.ballier <at> gmail.com> writes:
>> >> + ? ?case PIX_FMT_ARGB:
>> >> + ? ? ? ?s->pixel_size = 4;
>> >> + ? ? ? ?break;
>> >> ? ? ?default:
>> >> ? ? ? ? ?av_log(avctx, AV_LOG_ERROR, "Unsupported colorspace.\n");
>> >> ? ? ? ? ?break;
>> > unrelated?
>> sorry but I don't understand; setting pixel_size to the correct value
>> is needed by the rest of the encoder.
> You are expected to send two patches: One that fixes pixel_size for
> PIX_FMT_ARGB, one that adds RGB555 support.
The fact is that no part of the original patch was fixing anything,
only adding support for new pixel formats. The addition of both
formats was so similar and trivial that i didn't think it was worth
two different patches.
Anyway, here is a patch for argb since it'll probably be easier to
work on rgb555 if this is merged first.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 753 bytes
Desc: not available
More information about the ffmpeg-devel