[FFmpeg-devel] Neither vorbis_parse_setup_hdr_codebooks nor ff_vorbis_len2vlc verify data

[Reimar Döffinger]

On Wed, Jul 08, 2009 at 05:09:37PM +0200, Michael Niedermayer wrote:
> > Well, this one seems to work for the sample at least:
> > 
> > Index: vorbis_dec.c
> > ===================================================================
> > --- vorbis_dec.c        (revision 19365)
> > +++ vorbis_dec.c        (working copy)
> > @@ -292,7 +292,7 @@
> >              AV_DEBUG(" ordered, current length: %d \n", current_length);  //FIXME
> >  
> >              used_entries=entries;
> > -            for(;current_entry<used_entries;++current_length) {
> > +            for(;current_entry<used_entries && current_length <= 32;++current_length) {
> >                  uint_fast16_t i, number;
> >  
> >                  AV_DEBUG(" number bits: %d ", ilog(entries - current_entry));
> 
> ok

Applied.

> > 
> > Though I am not 100% confident this is all that is needed, so I'd prefer
> > to apply the other one at least in addition.
> 
> iam perfectily fine with that though would suggest with comments clarifying
> the possible redundancy

Done.