[FFmpeg-devel] [PATCH] Add SHA-2

[Michael Niedermayer]

On Fri, Jul 10, 2009 at 08:03:52AM +0300, Kostya wrote:
> On Fri, Jul 10, 2009 at 04:42:36AM +0200, Michael Niedermayer wrote:
> > On Thu, Jul 09, 2009 at 10:54:18AM +0300, Kostya wrote:
> > > On Wed, Jul 08, 2009 at 08:43:43PM +0200, Michael Niedermayer wrote:
> > > > On Wed, Jul 08, 2009 at 06:50:10PM +0300, Kostya wrote:
> > > > > On Wed, Jul 08, 2009 at 05:25:24PM +0200, Michael Niedermayer wrote:
> > > > > > On Wed, Jul 08, 2009 at 07:44:31AM +0300, Kostya wrote:
> > > > > > > I intend to at least try pushing RTMP client before continuing work on
> > > > > > > it, and SHA-2 is used there. That's why this patch is appearing again.
> > > > > > > 
> > > > > > > Note: files are renamed to sha.h and sha.c since they will contain code
> > > > > > > for both SHA-1 and SHA-2. Same for functions inside.
> > > > > > 
> > > > > [...]
> > > > > > > Index: libavutil/avutil.h
> > > > > > > ===================================================================
> > > > > > > --- libavutil/avutil.h	(revision 19141)
> > > > > > > +++ libavutil/avutil.h	(working copy)
> > > > > > > @@ -35,7 +35,7 @@
> > > > > > >  #define AV_VERSION(a, b, c) AV_VERSION_DOT(a, b, c)
> > > > > > >  
> > > > > > >  #define LIBAVUTIL_VERSION_MAJOR 50
> > > > > > > -#define LIBAVUTIL_VERSION_MINOR  3
> > > > > > > +#define LIBAVUTIL_VERSION_MINOR  4
> > > > > > >  #define LIBAVUTIL_VERSION_MICRO  0
> > > > > > >  
> > > > > > >  #define LIBAVUTIL_VERSION_INT   AV_VERSION_INT(LIBAVUTIL_VERSION_MAJOR, \
> > > > > > 
> > > > > > you cannot rename public headers (without a major version bump)
> > > > > > but iam not in favor of bumping now ...
> > > > > 
> > > > > First, this is unused inside FFmpeg (and Google code search shows only two
> > > > > projects which use it).
> > > > > Second, I'm pretty sure that there's no good time to bump major version.
> > > > > 
> > > > > Any suggestions on how to get the code in and/or justify major version bump are
> > > > > welcome.
> > > > 
> > > > if you really insist then rename the header, it just breaks compilation in a
> > > > fixable way not runtime. But iam not ok with any ABI breaks
> > >  
> > > OK, what about this compatibility layer?
> > 
> > mixes renamings, sha2 additions and probably other things that should be
> > split
> 
> Here's simple renaming and preparing for future SHA-2.
>  
> > [...]
> > -- 
> > Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

>  Makefile |    4 -
>  sha.c    |   58 ++++++++++++-----
>  sha.h    |   18 ++---
>  sha1.c   |  212 ---------------------------------------------------------------
>  sha1.h   |    3 
>  5 files changed, 56 insertions(+), 239 deletions(-)
> 183128e2b269fa450d5637db3674e7b9a1046527  sha-rename.patch

ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I hate to see young programmers poisoned by the kind of thinking
Ulrich Drepper puts forward since it is simply too narrow -- Roman Shaposhnik
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090710/09ef9529/attachment.pgp>