[FFmpeg-devel] [PATCH] Use ff_neterrno instead of errno in tcp.c

Måns Rullgård mans
Tue Jul 14 12:11:29 CEST 2009


Michael Niedermayer <michaelni at gmx.at> writes:

> On Tue, Jul 14, 2009 at 11:03:59AM +0300, Martin Storsj? wrote:
>> Hi,
>> 
>> The attached patch gives better consistency; if ff_neterrno() is checked 
>> instead of errno, that's probably what should be used in the return value, 
>> too. (On windows, network errors aren't visible in errno.)
>
> are the values of ff_neterrno compatible with errno values ?
> if yes the patch is obviously correct if no then there may be a problem

On real OSes ff_neterrno *is* errno.  On the others, this change can't
make things any worse...  I share your concern though.

-- 
M?ns Rullg?rd
mans at mansr.com



More information about the ffmpeg-devel mailing list