[FFmpeg-devel] [PATCH] libavfilter-soc: implement pad filter

Stefano Sabatini stefano.sabatini-lala
Wed Jul 15 01:03:12 CEST 2009

On date Thursday 2009-06-18 12:31:28 +0200, Michael Niedermayer encoded:
> On Thu, Jun 18, 2009 at 01:00:19AM +0200, Stefano Sabatini wrote:
> > Attached patches are not ready for review, consider it a
> > backup/proof-of-concept, still many points need to be addressed, in
> > particular:
> >  
> > * vflip filter is broken with the patch applied, the pad filter needs
> >   to be modified to work with negative logic too if possible, in the
> >   worst possible case maybe the vflip shouldn't be made slice-friendly
> >   as currently is.
> > 
> > * More docs to the new added fields are needed
> > 
> > * I suspect the new get_video_buffer API won't work with non-planar
> >   formats, also maybe a pixel format parameter has to be added to the
> >   params list.
> > 
> > * this patchset still doesn't implement direct rendering, both
> >   vsrc_movie/vsrc_buffer/ffplay need to be changed accordingly, but
> >   this may be a separate step.
> >  
> > * a lavfi regression test is required.
> > 
> > Feel free to have a look at any of these.
> ive too a long back log of stuff to look at the moment so i guess its better
> if you explicitly ask me to look at something if you need help or have
> a question or want a review ...

I changed the logic of the patches, now the buffer informations are
stored in the link rather than in the params.

This allows for simpler API usage, also makes it possible crop/pad
chains which caused troubles before. I'll provide a better explanation
with a further patchset, since these ones need to be cleaned up

Since the last version:
* fixed ffmpeg.c
* fixed hflip

Yet to come:
* fix vflip
* fix for leaks?
* add a regression test
* direct rendering is not implemented, it would be better to post it
  as a separate patchset since this is hard enough

I also suspect the exp_w, exp_h, x, y params in the picref are not really

FFmpeg = Fiendish Frenzy Merciful Proud Esoteric God
-------------- next part --------------
A non-text attachment was scrubbed...
Name: lavfi-recursive-get-video-buffer.patch
Type: text/x-diff
Size: 10941 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090715/058e8aab/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pad-implement.patch
Type: text/x-diff
Size: 14929 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090715/058e8aab/attachment-0001.patch>

More information about the ffmpeg-devel mailing list