[FFmpeg-devel] [PATCH] Fix --extra-cflags (broken in r19411)

Måns Rullgård mans
Mon Jul 20 21:03:37 CEST 2009

Art Clarke <aclarke at xuggle.com> writes:

> In r19411, the --extra-cflags configure flag was broken if/when you passed
> in multiple invocations of the flag.  Prior versions of FFmpeg this flag was
> additive.  Now, only the last value wins.  To produce the problem, do this:
> configure --extra-cflags -I/directory1 --extra-cflags -I/directory2
> This patch reverts that change, but I'm sure it doesn't fix whatever the
> original committer was trying to fix.  That said, no ffmpeg-devel review was
> done of the original patch, and the check-in note for r19411 doesn't say WHY
> the checkin was done, so I'll leave it to the author to figure out how to
> deal with it.

There was of course a reason for that change, which you can see in r19465.

I have restored the old behaviour of the option in a proper way.
Thanks for reporting the issue.

M?ns Rullg?rd
mans at mansr.com

More information about the ffmpeg-devel mailing list