[FFmpeg-devel] [PATCH][RFC] Indeo3 replacement

Diego Biurrun diego
Sat Jul 25 20:44:00 CEST 2009

On Sat, Jul 25, 2009 at 07:24:35PM +0200, Maxim wrote:
> Plz be merciful to me and help me out to make this stuff good-looking!
> Waiting for reviews...

On it...

> static av_cold void build_delta_tables(void)
> {
>     int             n, i, j, quads;
>     int32_t         a, b, corr;
>     int32_t         *delta_t, *quad_t, *delta_lo, *delta_hi;

These _t variable names look weird and I think _t is POSIX-reserved

> /**
>  *  Fill n lines with 64bit pixel value pix_hi:pix_lo
>  */
> static void fill_64(int32_t *dst, const int32_t pix_lo, const int32_t pix_hi,
>                      int32_t n, int32_t row_offset)


> static int decode_cell(Indeo3DecodeContext *ctx, AVCodecContext *avctx, Plane *plane, Cell *cell,
>                        const uint8_t *data_ptr, const uint8_t **last_ptr)

nit: long line

> {
>     int     x, y, buf_switch, mv_x, mv_y, mode, vq_index, prim_indx, second_indx, rle_blocks;
>     int     row_offset, blk_row_offset, line, num_lines, is_first_row, is_top_of_cell, skip_flag;
>     uint8_t code, *block, *ref_block, *prim_sel, *second_sel;
>     int32_t *prim_delta, *second_delta, *delta_tab, *src32, *ref32, *delta_lo, *delta_hi;


>     switch (mode) {
>         case 0: /*------------------ MODES 0 & 1 (4x4 block processing) --------------------*/
>         case 1:

K&R style does not indent the 'case' after the 'switch'.


More information about the ffmpeg-devel mailing list