[FFmpeg-devel] [PATCH] RTSP-MS 14/15: ASF packet parsing

Ronald S. Bultje rsbultje
Sun Jul 26 21:07:18 CEST 2009

Hi Michael,

On Sun, Jul 26, 2009 at 1:57 PM, Michael Niedermayer<michaelni at gmx.at> wrote:
> this should probably do more than just silently retunring
> also
> 1. please do not use 2 local variable with the name len
> 2. id write if(len > end - p)

OK, the function returns 0 on success, <0 on failure (documented), and
the caller (which has access to a log context and can thus do a nice
av_log()) will then print a message on failure. I also fixed the other
two issues you spotted.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: rtsp-ms-parse-asf-payload.patch
Type: text/x-diff
Size: 9351 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090726/cb4a183d/attachment.patch>

More information about the ffmpeg-devel mailing list