[FFmpeg-devel] [PATCH] RTSP-MS 14/15: ASF packet parsing

Ronald S. Bultje rsbultje
Sun Jul 26 22:49:54 CEST 2009


On Jul 26, 2009, at 4:09 PM, Michael Niedermayer <michaelni at gmx.at>  
> On Sun, Jul 26, 2009 at 03:07:18PM -0400, Ronald S. Bultje wrote:
>> On Sun, Jul 26, 2009 at 1:57 PM, Michael  
>> Niedermayer<michaelni at gmx.at> wrote:
>>> this should probably do more than just silently retunring
>>> also
>>> 1. please do not use 2 local variable with the name len
>>> 2. id write if(len > end - p)
>> OK, the function returns 0 on success, <0 on failure (documented),  
>> and
>> the caller (which has access to a log context and can thus do a nice
>> av_log()) will then print a message on failure. I also fixed the  
>> other
>> two issues you spotted.
> iam not maintainer of what remains :)

Well, that'd be me. I'd still prefer a second pair of eyes over  
patches before I commit. Anyway, if this is your OK then I'll commit  
next week unless anyone objects.


More information about the ffmpeg-devel mailing list