[FFmpeg-devel] [PATCH] Decoding of raw UTF-8 text from Ogg streams

Diego Biurrun diego
Mon Jul 27 14:11:56 CEST 2009


On Mon, Jul 27, 2009 at 12:37:12PM +0100, ogg.k.ogg.k at googlemail.com wrote:
> > I would guesstimate that at least 5 out of 10 people forget
> > documentation and changelog updates.  Can you give me a hint how to fix
> > this situation.  Why did you forget?  Where did you miss the
> > information?
> 
> I suspect it's an unconscious bias, but it might help to move:
> @section Development Policy, @section Submitting patches and friends
> to a CONTRIBUTING or HACKING file in the main directory. Or mention it
> specifically in the README.

That's a good hint, I'll see what I can do.

> --- a/Changelog
> +++ b/Changelog
> @@ -28,6 +28,8 @@ version <next>:
>  - DivX (XSUB) subtitle encoder
>  - nonfree libamr support for AMR-NB/WB decoding/encoding removed
>  - Experimental AAC encoder
> +- simple ASS/SSA decoder

subtitle decoder

> +- new avcodec_free_subtitle API.

Drop this line, just updating APIchanges is enough.

> --- a/libavcodec/allcodecs.c
> +++ b/libavcodec/allcodecs.c
> @@ -301,6 +301,7 @@ void avcodec_register_all(void)
>      REGISTER_ENCDEC  (DVDSUB, dvdsub);
>      REGISTER_ENCDEC  (XSUB, xsub);
> +    REGISTER_DECODER (SSA, ssa);

alphabetical order please

> --- /dev/null
> +++ b/libavcodec/ssadec.c
> @@ -0,0 +1,98 @@
> +/**
> + * @file libavcodec/ssedec.c

wrong filename

Diego



More information about the ffmpeg-devel mailing list