[FFmpeg-devel] [PATCH] Decoding of raw UTF-8 text from Ogg streams

[ogg.k.ogg.k at googlemail.com]

> why are you increasing lavf minor ? you're adding a decoder in lavc,
> aren't you ?

Because of the mention about it in developer.texi:
@section New codecs or formats checklist
[...]
@item
    Did you bump the minor version number in @file{avcodec.h} or
    @file{avformat.h}?

If a new decoder doesn't warrant a bump if the format was previously
demuxed, I'll resend without it, do you confirm it's OK ?

>> +#define LIBAVCODEC_VERSION_MINOR 35
>>  #define LIBAVCODEC_VERSION_MICRO  0
>>
>
> 32 + 1 = 33 ;)

Correct, but the Changelog mentioned minor 34, so I used
that as a base, in case some patch was pending.

>> +    if (!rect->ass) {
>> +        av_free(sub->rects[0]);
>> +        av_free(sub->rects);
>
> add a return AVERROR(ENOMEM); here...

Ah, embarassing, thanks.

I'll change the others and resend when there is confirmation that
the bump in version is not needed.