[FFmpeg-devel] [PATCH] RTSP-MS 14/15: ASF packet parsing

Michael Niedermayer michaelni
Tue Jul 28 02:44:00 CEST 2009

On Sun, Jul 26, 2009 at 04:49:54PM -0400, Ronald S. Bultje wrote:
> Hi,
> On Jul 26, 2009, at 4:09 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
>> On Sun, Jul 26, 2009 at 03:07:18PM -0400, Ronald S. Bultje wrote:
>>> On Sun, Jul 26, 2009 at 1:57 PM, Michael Niedermayer<michaelni at gmx.at> 
>>> wrote:
>>>> this should probably do more than just silently retunring
>>>> also
>>>> 1. please do not use 2 local variable with the name len
>>>> 2. id write if(len > end - p)
>>> OK, the function returns 0 on success, <0 on failure (documented), and
>>> the caller (which has access to a log context and can thus do a nice
>>> av_log()) will then print a message on failure. I also fixed the other
>>> two issues you spotted.
>> iam not maintainer of what remains :)
> Well, that'd be me. I'd still prefer a second pair of eyes over patches 
> before I commit.

of course but eyes are a limited resource, maybe you could talk to kostya
about that experiment in chernobyl

> Anyway, if this is your OK then I'll commit next week 
> unless anyone objects.

its not my ok, i didnt really review the code (yes i looked at it quickly
but looking at code one doesnt fully understand is no review)

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Republics decline into democracies and democracies degenerate into
despotisms. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090728/529b3961/attachment.pgp>

More information about the ffmpeg-devel mailing list