[FFmpeg-devel] [PATCH] Check for signal.h, conditionally compile parts of ffmpeg.c

Martin Storsjö martin
Wed Jul 29 00:37:33 CEST 2009

On Tue, 28 Jul 2009, M?ns Rullg?rd wrote:

> Martin Storsj? <martin at martin.st> writes:
> > On Tue, 28 Jul 2009, Ramiro Polla wrote:
> >
> >> On Fri, Jul 17, 2009 at 4:48 AM, Martin Storsj?<martin at martin.st> wrote:
> >> >
> >> > Here's another update to the patch series; I noticed that not all
> >> > HAVE_SIGNAL_H checks in ffmpeg.c were needed.
> >> 
> >> Is it necessary to check for HAVE_SIGNAL_H in the #ifdef HAVE_TERMIOS_H part?
> >
> > No, not for my use case. If termios.h existing implies signal.h existing 
> > too, I guess the check is redundant.
> signal.h is a mandatory part of standard C, and if that's not enough
> to ensure it exists everywhere, well...

Okay, well, in that case I guess I'll have to add hacks to the toolchain 
headers instead, to provide stubs for these functions, which didn't turn 
out to be any uglier than the earlier hacks I already have there. I got 
the impression in some earlier discussion that checking for signal.h would 
be acceptable.

// Martin

More information about the ffmpeg-devel mailing list