[FFmpeg-devel] [PATCH] G.729 initialization routine (skeleton)

Vladimir Voroshilov voroshil
Sat Jun 6 19:28:37 CEST 2009


2009/6/7 Diego Biurrun <diego at biurrun.de>:
> On Sun, Jun 07, 2009 at 12:18:10AM +0700, Vladimir Voroshilov wrote:
>>
>> Here is patch without format.
>>
>> --- ffmpeg-r19125.orig/libavcodec/g729dec.c
>> +++ ffmpeg-r19125.mod/libavcodec/g729dec.c
>> @@ -97,11 +101,39 @@ static inline int get_parity(uint8_t value)
>>
>> +static int decoder_init(AVCodecContext * avctx)
>
> This function should likely be marked av_cold.
>
> Please doublecheck which other functions could receive this attribute.
>

decoder_init does not call other internal routines, thus no additional
routines require this attribute, imho.
fixed.

-- 
Regards,
Vladimir Voroshilov     mailto:voroshil at gmail.com
JID: voroshil at gmail.com, voroshil at jabber.ru
ICQ: 95587719
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Initialization-routine.122.patch
Type: text/x-diff
Size: 1897 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090607/7a9733fc/attachment.patch>



More information about the ffmpeg-devel mailing list