[FFmpeg-devel] [PATCH] Fix MP2 audio detection for MPEGPS streams

[Taylor Ralph]

----- Original Message ----
> From: Taylor Ralph <tralph11 at yahoo.com>
> To: FFmpeg development discussions and patches <ffmpeg-devel at mplayerhq.hu>
> Sent: Sunday, June 7, 2009 3:06:13 PM
> Subject: Re: [FFmpeg-devel] [PATCH] Fix MP2 audio detection for MPEGPS streams
> 
> 
> Baptiste,
> 
> 
> 
> ----- Original Message ----
> > From: Baptiste Coudurier 
> > To: FFmpeg development discussions and patches 
> > Sent: Sunday, June 7, 2009 2:45:48 PM
> > Subject: Re: [FFmpeg-devel] [PATCH] Fix MP2 audio detection for MPEGPS streams
> > 
> > Hi,
> > 
> > Taylor Ralph wrote:
> > > I occasionally have an MPEGPS stream with MP2 audio that doesn't have audio 
> > due to the audio codec being misdetected as ADPCM_ADX. 
> > > 
> > > I've got a one-line patch that fixes the false detection when 
> > libavformat/mpeg.c tries to determine if the audio in an MPEGPS stream is MP2 
> or 
> > ADPCM_ADX. Basically a partial match of the string "Sofdec" will cause the 
> code 
> > to select ADPCM_ADX when it is actually MP2. I've opened a ticket here with a 
> > full explanation:
> > > 
> > > http://roundup.ffmpeg.org/roundup/ffmpeg/issue1149
> > > 
> > > The patch is here:
> > > 
> > > 
> > 
> http://roundup.ffmpeg.org/roundup/ffmpeg/file346/ffmpeg_fix_mp2_detect_new.diff
> > > 
> > > I can also provide a sample if someone would like it.
> > > 
> > 
> > A sample is definitely welcome.
> > 
> > -- 
> > Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
> > Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
> > FFmpeg maintainer                                  http://www.ffmpeg.org
> 
> OK. I've uploaded the sample to upload.ffmpeg.org located at:
> 
> /MPlayer/incoming/mp2audio_misdetect_issue1149/mp2audio_misdetect_issue1149.mpg
> 
> --
> Taylor
> 


This bug was introduced with the following commit to libavformat/mpeg.c:

r10967 | mru | 2007-11-08 16:27:37 -0500 (Thu, 08 Nov 2007) | 2 lines

Improve Sofdec file detection

--
Taylor