[FFmpeg-devel] [PATCH] Add DPX decoder rev-23

[Jimmy Christensen]

On 2009-06-10 10:27, Michael Niedermayer wrote:
> On Mon, Jun 08, 2009 at 11:47:42PM +0200, Jimmy Christensen wrote:
>> On 2009-06-08 16:12, Michael Niedermayer wrote:
>>> On Mon, Jun 08, 2009 at 12:17:32AM +0200, Jimmy Christensen wrote:
> [...]
>> +    switch (descriptor) {
>> +        case 51: // RGBA
>> +            elements = 4;
>> +            break;
>> +        case 50: // RGB
>> +            elements = 3;
>> +            break;
>
>> +        default:
>> +            av_log(avctx, AV_LOG_ERROR, "Unsupported descriptor\n");
>
> printing the value of the descriptor too, might be usefull
>

Added descriptor number to output.

>
>> +        default:
>> +            return -1;
>> +            break;
>
> thats impossible to be reached
>

Removed.

I was wondering how close this DPX patch is to get accepted. Is the 
general quality good enough or does it need to be approved a lot more?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ffmpegDPX-rev23.diff
Type: text/x-patch
Size: 10451 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090610/49ad2859/attachment.bin>