[FFmpeg-devel] [PATCH] Electronic Arts MAD Decoder

[Måns Rullgård]

Diego Biurrun <diego at biurrun.de> writes:

> On Wed, Jun 10, 2009 at 08:52:58PM +1000, Peter Ross wrote:
>> 
>> Patch updated.
>> 
>> --- libavcodec/eamad.c	(revision 0)
>> +++ libavcodec/eamad.c	(revision 0)
>> @@ -0,0 +1,323 @@
>> +
>> +static av_cold int mad_decode_init(AVCodecContext *avctx)
>
> All those mad_ prefixes for static functions are pointless.

I disagree.  When using a debugger, it helps if functions have unique
names.  Setting a breakpoint on, or merely seeing in a call stack, a
name like "decode" is ambiguous at best.  Unique names also help with
editors capable of jumping to a named symbol (emacs, vi, and many
others).

-- 
M?ns Rullg?rd
mans at mansr.com