[FFmpeg-devel] [PATCH] Electronic Arts MAD Decoder

[Michael Niedermayer]

On Wed, Jun 10, 2009 at 01:37:13PM +0100, M?ns Rullg?rd wrote:
> Diego Biurrun <diego at biurrun.de> writes:
> 
> > On Wed, Jun 10, 2009 at 08:52:58PM +1000, Peter Ross wrote:
> >> 
> >> Patch updated.
> >> 
> >> --- libavcodec/eamad.c	(revision 0)
> >> +++ libavcodec/eamad.c	(revision 0)
> >> @@ -0,0 +1,323 @@
> >> +
> >> +static av_cold int mad_decode_init(AVCodecContext *avctx)
> >
> > All those mad_ prefixes for static functions are pointless.
> 
> I disagree.  When using a debugger, it helps if functions have unique
> names.  Setting a breakpoint on, or merely seeing in a call stack, a
> name like "decode" is ambiguous at best.  Unique names also help with

debuggers should display the file name too


> editors capable of jumping to a named symbol (emacs, vi, and many
> others).

if the compiler can figure out which function is meant, so should an
editor

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The misfortune of the wise is better than the prosperity of the fool.
-- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090610/9e87f1d4/attachment.pgp>