[FFmpeg-devel] [PATCH] run level decode function for wma & wmapro

Sascha Sommer saschasommer
Fri Jun 12 11:07:36 CEST 2009


Hi,

On Donnerstag, 11. Juni 2009, Michael Niedermayer wrote:
> On Thu, Jun 11, 2009 at 10:17:19PM +0200, Sascha Sommer wrote:
> > Hi,
> >
> > attached patch adds a run level decode function that can be used for both
> > wma12 and wmapro.
>
> could you split it into a patch factorizig the code out and one
> changing it ?
> so that code moving around is seperate from functional changes ...
>
> [...]

Attached patch tries to simplify the run level decode code.
The order of the different cases for the codes is swapped so that the code < 0 
check can be dropped (may this happen anyway?). The table case that should be 
more likely than the escape case comes first now.

The overflow check was moved out of the loop.
Sign conversion was made branchless.

Regards

Sascha
-------------- next part --------------
A non-text attachment was scrubbed...
Name: shared_wma_rl_decode_try2_simplify.patch
Type: text/x-diff
Size: 2711 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090612/5db7d5cc/attachment.patch>



More information about the ffmpeg-devel mailing list