[FFmpeg-devel] [PATCH] Additional probing based on sequence header and group startcodes

[Baptiste Coudurier]

Jai Menon wrote:
> On Sat, Jun 13, 2009 at 9:29 PM, Baptiste
> Coudurier<baptiste.coudurier at gmail.com> wrote:
>> Michael Niedermayer wrote:
>>> On Sat, Jun 13, 2009 at 08:27:26PM +0000, Jai Menon wrote:
>>>> Hi,
>>>>
>>>> I'm not too familiar with the probing mechanism so any help is
>>>> appreciated. This might not be the right way to do it. Also, this
>>>> fixes issue 1185 and possibly others.
>>> [...]
>>>> diff --git a/libavformat/utils.c b/libavformat/utils.c
>>>> index dc18885..0096343 100644
>>>> --- a/libavformat/utils.c
>>>> +++ b/libavformat/utils.c
>>>> @@ -339,6 +339,9 @@ static int set_codec_from_probe_data(AVStream *st, AVProbeData *pd, int score)
>>>>          } else if (!strcmp(fmt->name, "dts")) {
>>>>              st->codec->codec_id = CODEC_ID_DTS;
>>>>              st->codec->codec_type = CODEC_TYPE_AUDIO;
>>>> +        } else if (!strcmp(fmt->name, "mpeg")) {
>>>> +            st->codec->codec_id = CODEC_ID_MPEG2VIDEO;
>>>> +            st->codec->codec_type = CODEC_TYPE_VIDEO;
>>>>          }
>>>>      }
>>>>      return !!fmt;
>>> this part is ok and can be commited seperately
>> Humm, what if stream contain H264 ? "mpeg" is mpeg ps demuxer.
> 
> Do you have any samples where avc isn't muxed with ES type 0x1b set in
> the stream map? I had thought about this too and hoped if nothing else
> to get a sample. And what should be done in this case? should the
> probing be done in the demuxer?
> 

No I don't have a sample. Thing is if "mpeg" matches this does not say
that stream contains mpeg2video. This case is handled by mpegvideo
probe. If this stream is not matched for a reason, the reason should be
in mpegvideo probe.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
FFmpeg maintainer                                  http://www.ffmpeg.org