[FFmpeg-devel] [PATCH] Add hwaccel_data infrastructure

[Michael Niedermayer]

On Tue, Mar 03, 2009 at 01:29:17PM +0100, Gwenole Beauchesne wrote:
> Hi,
>
> This patch implements the suggested hwaccel_data infrastructure.
>
> - hwaccel_data is allocated by the player and matches what we currently 
> name vdpau_render_state or vaapi_render_state. The aim is to replace the 
> use of AVCodecContext::data[0] (reserved for YV12 pixels -- future use).

is there an advantage over using data[3] ?


>
> - hwaccel_data_private is optional (check AVHWAccel::priv_data_size) and 
> allocated by FFmpeg. This private data has the lifetime of the decoded 
> AVFrame. It's deallocated through the ::close() function. I don't really 
> like the name. For VA API, I implemented it as ff_vaapi_destroy_picture().

this looks asymetric
alloc by av_mallocz()
close by callback
why?

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is not what we do, but why we do it that matters.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090303/4791c3e3/attachment.pgp>