[FFmpeg-devel] [PATCH] mov.c: factorize ff_mov_read_stsd_entries()

Ronald S. Bultje rsbultje
Mon Mar 9 23:41:35 CET 2009


Hi Baptiste,

On Mon, Mar 9, 2009 at 5:57 PM, Baptiste Coudurier
<baptiste.coudurier at gmail.com> wrote:
> Well I would prefer if the whole function would get changed to parse
> these structures and populate a MOVStsd struct. You could then use these
> structs. Besides I believe it would be easier to then create separate
> tracks and handle multiple data reference.

I think that was my initial intention, but then it wasn't possible
because the palette reading code halfway that function directly
touches stuff in MOVContext. I didn't look too deeply, so it may in
fact be possible to move that stuff away from MOVContext into MOVStsd
and then this would indeed be a good approach, at least much better
than initializing the complete QT demuxer just to read one atom...

Are you familiar with the palette reading code? Can it be moved (can I
move it) into MOVStsd without problems? Any reason it isn't there
already?

Thanks for the review,
Ronald




More information about the ffmpeg-devel mailing list