[FFmpeg-devel] [PATCH][VAAPI][2/6] Add common data structures and helpers (take 7)

Gwenole Beauchesne gbeauchesne
Wed Mar 11 14:20:54 CET 2009


On Wed, 11 Mar 2009, Michael Niedermayer wrote:

> [...]
>> +/** This structure holds all temporary data for VA API decoding */
>> +struct vaapi_render_state_private {
>
>> +    VADisplay       display;                ///< Window system dependent data (copied from vaapi_render_state->va_context)
>> +    VAContextID     context_id;             ///< Context ID (video decode pipeline, copied from vaapi_render_state->va_context)
>> +    VASurfaceID     surface;                ///< Rendering surface (copied from vaapi_render_state->va_context)
>
> copying data is generally not a good idea, its a receipe for ending up
> with different data and bugs

Dropped them but kept vaapi_context as is since "copying data is generally 
not a good idea".

New patch attached.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ffmpeg.hwaccel.vaapi.common.7.patch
Type: text/x-diff
Size: 14844 bytes
Desc: 
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090311/74da73cd/attachment.patch>



More information about the ffmpeg-devel mailing list