[FFmpeg-devel] [PATCH][VAAPI][2/6] Add common data structures and helpers (take 9)

Gwenole Beauchesne gbeauchesne
Thu Mar 12 13:14:59 CET 2009

On Thu, 12 Mar 2009, Diego Biurrun wrote:

> On Thu, Mar 12, 2009 at 06:09:08AM +0100, Gwenole Beauchesne wrote:
>> Le 12 mars 09 ? 01:27, Michael Niedermayer a ?crit :
>>>> +    slice_param->slice_data_size        = size;
>>>> +    slice_param->slice_data_offset      = p->slice_data_size;
>>>> +    slice_param->slice_data_flag        = VA_SLICE_DATA_FLAG_ALL;
>>> extra useless whitespace
>> Oh, it's great, you are now focusing on cosmetics, so this means the
>> rest is correct!
> There is a pattern emerging here: You get a multitude of comments, some
> of them minor in nature, you use the minor comments as a pretext to
> flame.  However, the time you waste flaming exceeds the time it takes
> to adjust those minor nits.

(i) I don't get/see a multitude of comments, (ii) you are not really 
commenting the other bits either, only the minor chunk you quoted, (iii) 
do you really want new patches when only 15 spaces, two comments and a few 
assert()'s were removed? Do the extra spaces really prevent you from 
seeing other problems?

Anyway, attached the current patch for your own pleasure...
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ffmpeg.hwaccel.vaapi.common.10.patch
Type: text/x-diff
Size: 13504 bytes
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090312/36a00a03/attachment.patch>

More information about the ffmpeg-devel mailing list