[FFmpeg-devel] [PATCH] Common code for Indeo interactive

[Maxim]

Aurelien Jacobs schrieb:
> On Thu, Mar 19, 2009 at 11:12:40PM +0100, Maxim wrote:
>   
>> Hello guys,
>>
>> here is the 1st part of my patch making FFmpeg decode Indeo interactive
>> (indeo4/indeo5) streams. Both codecs are very similar but use abit
>> different bitstream formats, so I decided myself to put all common
>> functions and tables together and submit them as a separate patch.
>> The 2nd part will be the long-awaited indeo5 decoder...
>> Please review!
>>
>> [...]
>>
>> /**
>>  *  motion compensation without adding delta
>>  *
>>  *  @param  buf     [in,out] pointer to the block in the current frame receiving the result
>>  *  @param  ref_buf [in] pointer to the corresponding block in the reference frame
>>  *  @param  pitch   [in] pitch for moving to the next y line
>>  *  @param  mc_type [in] interpolation type
>>  */
>> static void ivi_mc_8x8_no_delta (int16_t *buf, int16_t *ref_buf, uint32_t pitch, int mc_type)
>>     
>
>
> This function probably is exactly the same as put_pixels_tab[1][mc_type]()
> from dsputils. And you can probably also use dsputils for all other MC
> functions.
>   
Thank you for the tip. I'll look into it. When it can be replaced, I'll
definitely do it...
> Also your code would benefit from some vertical alignment all over the place,
> in the code and the data tables.
>   
Not sure I understand what you mean but I'll recheck the alignment...

Regards
Maxim