[FFmpeg-devel] [PATCH] G722 decoder

Diego Biurrun diego
Sat Mar 21 09:47:34 CET 2009


On Sat, Mar 21, 2009 at 12:43:35AM -0700, Kenan Gillet wrote:
> 
> Here is an implementation of a bitexact G.722 decoder.
> 
> --- libavcodec/allcodecs.c	(revision 18096)
> +++ libavcodec/allcodecs.c	(working copy)
> @@ -268,6 +268,7 @@
>      REGISTER_DECODER (ADPCM_EA_XAS, adpcm_ea_xas);
>      REGISTER_ENCDEC  (ADPCM_G726, adpcm_g726);
> +    REGISTER_DECODER (ADPCM_G722, adpcm_g722);

alphabetical order

> --- libavcodec/g722dec.c	(revision 0)
> +++ libavcodec/g722dec.c	(revision 0)
> @@ -0,0 +1,275 @@
> +/*
> + * G.722 ADPCM audio decoder
> + *
> + * Copyright (c) 2005 Steve Underwood <steveu at coppice.org>
> + * Copyright (c) CMU 1993 Computer Science, Speech Group
> + *                        Chengxiang Lu and Alex Hauptmann

Who wrote this?  Do you have permission to license as LGPL?

> +/**
> + * adpative preditor

What?

> +static int inline scale(const int log_factor, int shift) {

Place the { on the next line like you do everywhere else.

> --- libavformat/allformats.c	(revision 18096)
> +++ libavformat/allformats.c	(working copy)
> @@ -84,6 +84,7 @@
>      REGISTER_MUXER    (FRAMECRC, framecrc);
>      REGISTER_MUXER    (GIF, gif);
> +    REGISTER_MUXDEMUX (G722, g722);
>      REGISTER_DEMUXER  (GSM, gsm);

Move this up one line into alphabetical order.

Diego




More information about the ffmpeg-devel mailing list