[FFmpeg-devel] [PATCH] Adding support for OSX bundles to ffmpeg command line

[Benoit Fouet]

On 03/21/2009 03:39 AM, Chris Marrin wrote:
> On Mar 20, 2009, at 5:47 PM, Stefano Sabatini wrote:
>
>   
>> On date Friday 2009-03-20 14:24:30 -0700, Chris Marrin encoded:
>>     
>>> On Mar 20, 2009, at 7:40 AM, Benoit Fouet wrote:
>>>
>>> [...]
>>>
>>>       
>>>> this is mixing functionnal and cosmetical changes
>>>>         
>>> Could you be more specific? I believe all I have done is added a  
>>> check
>>> to see if the preset is at a path relative to the executable_path.
>>> Then (after a check for a successful open) I go into the existing
>>> codepath.
>>>       
>> Reindenting should be done in a separate patch, so each patch is
>> minimal and more readable.
>>
>> You can use git/quilt/whatever to create stack of patches.
>>     
>
>
> You mean the indenting due to the extra "if (!f)" test? Hmmm, that  
> seems odd. It would mean submitting a patch with incorrect  
> indentation, which seems confusing. Is that really the submission  
> style for ffmpeg?
>
>   

Yes.
One patch for the functionnal part; and another one to reindent the code
(the cosmetical part).

Ben