[FFmpeg-devel] [PATCH][VAAPI][3/6] Add MPEG-2 bitstream decoding (take 6)

[Michael Niedermayer]

On Mon, Mar 23, 2009 at 11:23:38AM +0100, Gwenole Beauchesne wrote:
> On Sun, 22 Mar 2009, Gwenole Beauchesne wrote:
>
>> Le 22 mars 09 ? 04:05, Michael Niedermayer a ?crit :
>>
>>>> +/** Is the current field the first field for field picture? */
>>>> +static inline int mpeg2_get_is_first_field(MpegEncContext *s)
>>>> +{
>>>> +    return s->first_field || s->picture_structure == PICT_FRAME;
>>>> +}
>>> picture_structure == PICT_FRAME are not field pics
>>
>> Actually, VA API first_field means !second_field and this is the same 
>> condition as mpeg_field_start()'s. Hmm, I will have to visually check for 
>> this one.
>
> Yes, I confirm this, this needs to remain as is. i.e. first_field is 
> !second-field, which is
> !(s->picture_structure != PICT_FRAME && !s->first_field), and thus
> s->first_field || s->picture_structure == PICT_FRAME
> ;-)
>
> New patch attached to fix other cosmetics too.

ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is not what we do, but why we do it that matters.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090323/1bbd1382/attachment.pgp>