[FFmpeg-devel] [Fwd: Summer of code small task patch]

[Michael Niedermayer]

On Mon, Mar 30, 2009 at 12:16:48AM +0200, Dylan Yudaken wrote:
> Michael Niedermayer wrote:
>>
>>> Index: libavcodec/fdctref.c
>>> ===================================================================
>>> --- libavcodec/fdctref.c	(revision 18226)
>>> +++ libavcodec/fdctref.c	(working copy)
>>> @@ -1,157 +1,128 @@
>>> -/**
>>> - * @file libavcodec/fdctref.c
>>> - * forward discrete cosine transform, double precision.
>>> - */
>>> -
>>> -/* Copyright (C) 1996, MPEG Software Simulation Group. All Rights 
>>> Reserved. */
>>> -
>>>  /*
>>> - * Disclaimer of Warranty
>>> + * Reference discrete cosine transform (double-precision)
>>> + * Copyright (C) 2009 Dylan Yudaken
>>>     
>>
>> the patch should remove the old file and add the new file, it should not
>> be a (unreadable) diff betweem 2 different implementations
>>   
> sorry - I am struggling to separate into 2 clear patches. I have attached 1 
> patch, I think diego said he would split it up. I cant find a way to do a 
> local commit on svn so that I can diff between different stages of my 
> patch.

you can just make a second directory and diff between 2 files or directories
with diff -u

(there are other ways also like using git but git probably needs too much
 time to learn for this purpose now)


[...]
> +    coefficients[0] = 1;
> +    for (i = 8; i < 64; i+=8) {
> +        for (j = 0; j < 8; ++j) {
> +            coefficients[i + j] = sqrt(2.0) * cos(i * (j+0.5) * (M_PI / 64.0));
> +        }
> +        coefficients[i/8] = 1;
> +    }

theres a simpler way by which the loops can be merged

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

While the State exists there can be no freedom; when there is freedom there
will be no State. -- Vladimir Lenin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090330/e1e769e1/attachment.pgp>