[FFmpeg-devel] [Fwd: Summer of code small task patch]

Dylan Yudaken dyudaken
Tue Mar 31 10:50:25 CEST 2009



Diego Biurrun wrote:
> On Tue, Mar 31, 2009 at 08:52:30AM +0200, Dylan Yudaken wrote:
>   
>> --- a/libavcodec/dct-test.c
>> +++ b/libavcodec/dct-test.c
>>     
>
> I dunno how you created this patch, but it seems you did not use
> mechanical search and replace - bad idea, some typos crept in.
>   

very annoying that. sorry. it was only under processors I dont use
>   
>> --- a/libavcodec/dct-test.c
>> +++ b/libavcodec/dct-test.c
>> @@ -90,57 +90,57 @@ struct algo {
>>  
>>  #if HAVE_ALTIVEC
>> -  {"altivecfdct",     0, fdct_altivec,       fdct, NO_PERM, FF_MM_ALTIVEC},
>> +  {"altivecfdct",     0, fdct_altivec,       ff_ref_dct, NO_PERM, FF_MM_ALTIVEC},
>>     
>
> typo
>
>   
>>  #if ARCH_ALPHA
>> -  {"SIMPLE-ALPHA",    1, ff_simple_idct_axp,  idct, NO_PERM },
>> +  {"SIMPLE-ALPHA",    1, ff_simple_idct_axp,  ref_idct, NO_PERM },
>>     
>
> another typo
>
> Diego
>
> P.S.: Dylan, your patches have mime-type application/mbox, this is weird
> and not helpful when trying to view patches inline.
>   

hmm, I was using git-format-patch. these were attached using git-diff.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: newdctref.diff
Type: text/x-patch
Size: 9866 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090331/df7e6e83/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: renameolddct.diff
Type: text/x-patch
Size: 6245 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090331/df7e6e83/attachment-0001.bin>



More information about the ffmpeg-devel mailing list