[FFmpeg-devel] [Fwd: Summer of code small task patch]

Diego Biurrun diego
Tue Mar 31 11:00:11 CEST 2009


On Tue, Mar 31, 2009 at 10:50:25AM +0200, Dylan Yudaken wrote:
> 
> Diego Biurrun wrote:
> >On Tue, Mar 31, 2009 at 08:52:30AM +0200, Dylan Yudaken wrote:
> >  
> >>--- a/libavcodec/dct-test.c
> >>+++ b/libavcodec/dct-test.c
> >
> >I dunno how you created this patch, but it seems you did not use
> >mechanical search and replace - bad idea, some typos crept in.
> 
> very annoying that. sorry. it was only under processors I dont use

I just committed the updated version of your rename patch.

> --- /dev/null
> +++ b/libavcodec/dctref.c
> @@ -0,0 +1,121 @@
> +/*
> + * Reference discrete cosine transform (double-precision)

reference

> +/**
> + * @file libavcodec/dctref.c
> + * Reference discrete cosine transform (double-precision)

ditto

> + * @note This file could be optimised a lot, but is for

optimiZed

> + * reference and so readability is better

End sentences in a period please.

> +/**
> + * Initialize the Double Precision Discrete Cosine Transform

pointless capitalization

> +    /* block = out*(coefficients') */

Is the ' a mistake?

> +/**
> + * Transform 8x8 block of data with an double precision inverse DCT <br>

s/an/a/

Diego



More information about the ffmpeg-devel mailing list